Github user vkorukanti commented on a diff in the pull request:

    https://github.com/apache/drill/pull/462#discussion_r58742546
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java
 ---
    @@ -169,4 +176,223 @@ private static boolean containIdentity(List<? extends 
RexNode> exps,
         }
         return true;
       }
    +
    +  /**
    +   * Copied from {@link RelOptUtil#splitJoinCondition(RelNode, RelNode, 
RexNode, List, List)}. Modified to rewrite
    --- End diff --
    
    I will followup with a JIRA on Calcite project to see if we can push this 
change to Calcite. 
    
    The function ```RelOptUtil#splitJoinCondition``` in the current form itself 
seems to have a problem/limitation. Currently it just returns the left and 
right join key indices, but doesn't return whether the condition is ```EQUAL``` 
or ```IS NOT DISTINCT FROM``` (it adds the key pair if they have either of 
these function in comparison). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to