Github user vkorukanti commented on the pull request:

    https://github.com/apache/drill/pull/462#issuecomment-210056992
  
    I haven't tried this, but wondering whether this is sufficient to handle 
mix of EQUALS and IS NOT DISTINCT FROM cases.  Maintain a list (one for each 
join condition) instead of single "areNullsEquals" flag in MergeJoinBatch [1] 
and ChainedHashTable [2] and generate the code accordingly for each condition.
    
    [1] 
https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java#L463
    
    [2] 
https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/ChainedHashTable.java#L251


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to