Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/462#discussion_r58751332
--- Diff:
exec/java-exec/src/main/codegen/templates/ComparisonFunctions.java ---
@@ -215,6 +192,36 @@ public void eval() {
}
}
+ <#-- IS_DISTINCT_FROM function -->
+ @FunctionTemplate(names = {"is_distinct_from", "is distinct from" },
--- End diff --
I am not opposed to having a native implementation of IS [NOT] DISTINCT
FROM...clearly the generated code is more compact; however adding this new
functions means we would need proper functional test coverage for various data
types. Any thoughts regarding that ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
