Github user chunhui-shi commented on the pull request:
https://github.com/apache/drill/pull/430#issuecomment-206578634
@jacques-n
The email response is not pushed here. So copy the sent email as below:
Thanks for pointing to openHFT. Yes, I went through multiple Java
implementations including this one. The reason I decided to use smhasher as the
source of truth was, the smhasher implementation includes comprehensive tests
to cover the attributes for measuring goodness of a non-cryptographic hash
function. And these attributes are subtle and could be found out to be a
problem maybe only on certain lengths of input. So when I looked at these
implementations, I checked what tests they have done first. And since there is
no such tests(test multiple attributes and lengths) in these Java
implementations to prove the hash functions are correct or good. So I decided
to start from smhasher implementations and used the results generated from
smhasher to verify any other(including drill's) implementation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
