Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/430#issuecomment-207153608
@jacques-n regarding re-implementation, agree with the general concern;
however in this case the core logic is directly taken from the java based
murmur hash implementation (compared to the XXHash that was ported from C).
The OpenHFT discussion happened a little late in the cycle but in any case it
seems fairly young project that is run by 1 company. We could re-visit it in
future. When discussing the hash functions with @chunhui-shi we really want to
get to a stage where Drill could allow a few different hash functions/library
to exist and choose based on an external setting.
Regarding performance, we have done a couple of rounds of testing but
likely will do another one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
