Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r58967081
--- Diff:
common/src/main/java/org/apache/drill/common/util/DrillStringUtils.java ---
@@ -163,10 +163,10 @@ private static void appendByte(StringBuilder result,
byte b) {
public static int parseBinaryString(ByteBuf str, int strStart, int
strEnd) {
int length = (strEnd - strStart);
int dstEnd = strStart;
- for (int i = strStart; i < length ; i++) {
+ for (int i = strStart; i < strStart+length ; i++) {
--- End diff --
I believe you don't need length, and can just compare with strEnd
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
