Github user jinfengni commented on a diff in the pull request:
    --- Diff: 
    @@ -139,6 +155,11 @@ public ParquetRecordReader(
         this.batchSize = batchSize;
         this.footer = footer;
         this.fragmentContext = fragmentContext;
    +    if (numRecordsToRead == DEFAULT_RECORDS_TO_READ_NOT_SPECIFIED) {
    +      this.numRecordsToRead =  
    +    } else {
    +      this.numRecordsToRead = numRecordsToRead;
    --- End diff --
    I assume numRecordsToRead should be within range of [1, rowCount].  Do we 
need enforce such range? What if I pass in 0 or  rowCount + 100 ? 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to