Github user jinfengni commented on a diff in the pull request:
    --- Diff: 
    @@ -117,4 +119,18 @@ public void testSelectEmptyNoCache() throws Exception {
             uex.getMessage()), uex.getMessage().contains(expectedMsg));
    +  @Test
    +  public void testLimit() throws Exception {
    +    List<QueryDataBatch> results = 
testSqlWithResults(String.format("select * from cp.`parquet/limitTest.parquet` 
limit 1"));
    --- End diff --
    In stead of using a new parquet file, you may consider using 
cp.`tpch/nation.parquet`, unless the new file has some properties that the 
existing files do not have. It's preferable to use existing file, since 1) 
reduce drill package size, 2) people is more familiar with tpch sample files; 
making it easier to understand the expected result.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to