Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/597#discussion_r83334160
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java
 ---
    @@ -115,17 +118,30 @@
       public ParquetRecordReader(FragmentContext fragmentContext,
           String path,
           int rowGroupIndex,
    +      long numRecordsToRead,
           FileSystem fs,
           CodecFactory codecFactory,
           ParquetMetadata footer,
           List<SchemaPath> columns) throws ExecutionSetupException {
    -    this(fragmentContext, DEFAULT_BATCH_LENGTH_IN_BITS, path, 
rowGroupIndex, fs, codecFactory, footer,
    -        columns);
    +    this(fragmentContext, DEFAULT_BATCH_LENGTH_IN_BITS, numRecordsToRead,
    +         path, rowGroupIndex, fs, codecFactory, footer, columns);
    +  }
    +
    +  public ParquetRecordReader(FragmentContext fragmentContext,
    +      String path,
    +      int rowGroupIndex,
    +      FileSystem fs,
    +      CodecFactory codecFactory,
    +      ParquetMetadata footer,
    +      List<SchemaPath> columns) throws ExecutionSetupException {
    +      this(fragmentContext, DEFAULT_BATCH_LENGTH_IN_BITS, 
DEFAULT_RECORDS_TO_READ_NOT_SPECIFIED,
    --- End diff --
    
    I think we can get rid of DEFAULT_RECORDS_TO_READ_NOT_SPECIFIED. If  
numRecordsToRead is not specified,  just use rowCount in the row Group. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to