Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r99390401
--- Diff: exec/java-exec/src/main/codegen/data/Parser.tdd ---
@@ -39,7 +39,13 @@
"METADATA",
"DATABASE",
"IF",
- "JAR"
+ "JAR",
+ "ANALYZE",
+ "COMPUTE",
+ "ESTIMATE",
+ "STATISTICS",
+ "SAMPLE",
+ "PERCENT"
--- End diff --
Adding so many "good" words as keywords will break existing queries:
```
SELECT estimate, percent FROM sample
```
Would, presumably, work prior to this commit, but will fail after. Or, were
those keywords already reserved?
Do we have to consider backward compatibility here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
