Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/729#discussion_r99392582
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java ---
    @@ -392,6 +402,11 @@ public String getQueryUserName() {
         return fragment.getCredentials().getUserName();
       }
     
    +  /**
    +   * @return ID {@link java.util.UUID} of the current query
    +   */
    +  public String getQueryId() { return 
QueryIdHelper.getQueryId(fragment.getHandle().getQueryId());}
    --- End diff --
    
    We use the term "query ID" for the numeric version of the query ID as shown 
by the `getHandle().getQueryId()` method. Suggestion: rename this to 
'getQueryIdString`. And, if we do that, provide a version that returns the 
original query ID. That is:
    ```
    public QueryId getQueryId() { return fragment.getHandle().getQueryId(); }
    public String getQueryIdString() { return 
QueryIdHelper.getQueryId(getQueryId()); }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to