Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r99391067
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -390,4 +391,15 @@
String DYNAMIC_UDF_SUPPORT_ENABLED = "exec.udf.enable_dynamic_support";
BooleanValidator DYNAMIC_UDF_SUPPORT_ENABLED_VALIDATOR = new
BooleanValidator(DYNAMIC_UDF_SUPPORT_ENABLED, true, true);
+
+ /**
+ * Option whose value is a long value representing the number of bits
required for computing ndv (using HLL)
+ */
+ LongValidator NDV_MEMORY_LIMIT = new
PositiveLongValidator("exec.statistics.ndv_memory_limit", 30, 20);
--- End diff --
These validators are used for user-settable system or session options. The
user can choose the NDV bit count? What happens if I do one run with one value,
the next run with a different value? Do we handle a mix of lengths? If we
don't, should this e a runtime option?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
