Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/931#discussion_r136601989
--- Diff:
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/MapRDBSubScan.java
---
@@ -71,14 +71,32 @@ public MapRDBSubScan(String userName,
MapRDBFormatPlugin formatPlugin,
this.tableType = tableType;
}
+
+ @JsonProperty("formatPluginConfig")
--- End diff --
There are trade-offs with serializing/deserializing more than the minimum
needed. One is the extra amount of data being sent as part of the plan
fragment. Another, somewhat more problematic is that the serialization brings
in dependent classes and if the latter are not serialized properly then query
fails. Any thoughts about these ? I understand the motivation for the change
to fix DRILL-5714 and subsequently this Jira. Just want to explore it further
to see if the downsides can be avoided.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
