Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/931#discussion_r136605378
  
    --- Diff: 
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/MapRDBSubScan.java
 ---
    @@ -71,14 +71,32 @@ public MapRDBSubScan(String userName, 
MapRDBFormatPlugin formatPlugin,
         this.tableType = tableType;
       }
     
    +
    +  @JsonProperty("formatPluginConfig")
    --- End diff --
    
    We need to serialize `formatPluginConfig` to be able to create 
`MapRDBFormatPlugin` during deserialization.
    `MapRDBFormatPluginConfig` contains five fields only:
    ```
      public boolean allTextMode = false;
      public boolean enablePushdown = true;
      public boolean ignoreSchemaChange = false;
      public boolean readAllNumbersAsDouble = false;
      public boolean disableCountOptimization = false;
    ```
    Regarding the change, DRILL-5714 fixed initially incorrect implementation 
logic in `MapRDBSubScan`. 
    Current implementation is similar to `EasySubScan`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to