Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/931#discussion_r136856876
--- Diff:
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/MapRDBSubScan.java
---
@@ -71,14 +71,32 @@ public MapRDBSubScan(String userName,
MapRDBFormatPlugin formatPlugin,
this.tableType = tableType;
}
+
+ @JsonProperty("formatPluginConfig")
--- End diff --
Ok, yes since the fields are primitive types, they are not adding a
dependency on other classes.
Separately, we need to increase test coverage for these types of
serialization/deserialization issues for the most commonly used storage and
format plugins but that's a different discussion.
I am good with this. +1
---
