Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/923#discussion_r137937210
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/DrillConfigIterator.java
---
@@ -58,17 +58,17 @@ public OptionValue next() {
OptionValue optionValue = null;
switch(cv.valueType()) {
case BOOLEAN:
- optionValue = OptionValue.createBoolean(OptionType.BOOT, name,
(Boolean) cv.unwrapped(), OptionScope.BOOT);
+ optionValue = OptionValue.create(OptionType.BOOT, name, (Boolean)
cv.unwrapped(), OptionScope.BOOT);
--- End diff --
I suppose this has worked, but it is a bit of a muddle. Config settings are
not runtime options. It is a hack to map them into the same structures. Since
this iterator is probably only used to create a table, at some point we
probably should create a new object to handle config options. We might want: 1)
the full name, 2) the source (system options, command line,
drill-override.conf, etc.), 3) the TypeSafe type (which is a superset of the
runtime option types.
OK to leave this for now, but we should consider fixing this in the future.
---
