[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

[paul-rogers]

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/923#discussion_r137937977
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/work/metadata/TestMetadataProvider.java
 ---
    @@ -196,9 +200,12 @@ public void tablesWithSystemTableFilter() throws 
Exception {
         verifyTable("sys", "boot", tables);
         verifyTable("sys", "drillbits", tables);
         verifyTable("sys", "memory", tables);
    -    verifyTable("sys", "options", tables);
    +    verifyTable("sys", SystemTable.OPTION.getTableName(), tables);
    +    verifyTable("sys", SystemTable.OPTION_VAL.getTableName(), tables);
         verifyTable("sys", "threads", tables);
         verifyTable("sys", "version", tables);
    +    verifyTable("sys", SystemTable.INTERNAL_OPTIONS.getTableName(), 
tables);
    +    verifyTable("sys", SystemTable.INTERNAL_OPTIONS_VAL.getTableName(), 
tables);
    --- End diff --
    
    Thanks for providing the constants. Nice improvement.


---