Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/923#discussion_r137937864
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLimitWithExchanges.java
---
@@ -71,7 +72,8 @@ public void testPushLimitPastUnionExchange() throws
Exception {
final String[] expectedPlan5 =
{"(?s)Limit\\(fetch=\\[1\\].*UnionExchange.*Limit\\(fetch=\\[1\\]\\).*Join"};
testLimitHelper(sql5, expectedPlan5, excludedPlan, 1);
} finally {
- test("alter session set `planner.slice_target` = " +
ExecConstants.SLICE_TARGET_OPTION.getDefault().getValue());
+ final OperatorFixture.TestOptionSet testOptionSet = new
OperatorFixture.TestOptionSet();
+ test("alter session set `planner.slice_target` = " +
testOptionSet.getDefault(ExecConstants.SLICE_TARGET).getValue());
--- End diff --
Here, seems it would be better to refer to the constant defining the option
name rather than hard-coding it. (Yes, this is existing code, so OK to leave as
is...)
---
