[GitHub] drill pull request #1001: JIRA DRILL-5879: Like operator performance improve...

[sachouche]

Github user sachouche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1001#discussion_r145746250
  
    --- Diff: 
exec/java-exec/src/main/codegen/templates/CastFunctionsSrcVarLenTargetVarLen.java
 ---
    @@ -73,6 +73,9 @@ public void eval() {
         out.start =  in.start;
         if (charCount <= length.value || length.value == 0 ) {
           out.end = in.end;
    +      if (charCount == (out.end-out.start)) {
    +        out.asciiMode = 1; // we can conclude this string is ASCII
    --- End diff --
    
    will do!


---