Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1001#discussion_r146390381
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CharSequenceWrapper.java
 ---
    @@ -53,13 +55,13 @@
       // The end offset into the drill buffer
       private int end;
       // Indicates that the current byte buffer contains only ascii chars
    -  private boolean usAscii;
    +  private boolean useAscii;
     
       public CharSequenceWrapper() {
       }
     
       public CharSequenceWrapper(int start, int end, DrillBuf buffer) {
    -    setBuffer(start, end, buffer);
    +    setBuffer(start, end, buffer, -1);
    --- End diff --
    
    what does -1 mean ? Shouldn't it be one of CHAR_MODE_IS_ASCII, 
CHAR_MODE_UNKNOWN or CHAR_MODE_NOT_ASCII ?



---

Reply via email to