Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1059#discussion_r155939311
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
 ---
    @@ -535,4 +537,25 @@ public void close() {
         }
         super.close();
       }
    +
    +  @Override
    +  protected boolean checkForEarlyFinish() {
    +    if (joinType == JoinRelType.INNER &&
    +        (leftUpstream == IterOutcome.NONE || rightUpstream == 
IterOutcome.NONE) ||
    +        joinType != JoinRelType.INNER &&
    +        (leftUpstream == IterOutcome.NONE && rightUpstream == 
IterOutcome.NONE)) {
    +      return true;
    +    }
    +    return false;
    --- End diff --
    
    An explanation of the logic (in the form of a comment) would be very 
helpful.


---

Reply via email to