[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

[paul-rogers]

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1059#discussion_r155939459
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java
 ---
    @@ -333,4 +342,96 @@ public void testNlJoinWithLargeRightInputSuccess() 
throws Exception {
           test(RESET_JOIN_OPTIMIZATION);
         }
       }
    +
    +  private void buildFile(String fileName, String[] data, File testDir) 
throws IOException {
    +    try(PrintWriter out = new PrintWriter(new FileWriter(new File(testDir, 
fileName)))) {
    +      for (String line : data) {
    +        out.println(line);
    +      }
    +    }
    +  }
    +
    +  @Test
    +  public void testNestedLeftJoinWithEmptyTable() throws Exception {
    +    test(DISABLE_JOIN_OPTIMIZATION);
    +    test(DISABLE_NLJ_SCALAR);
    +    test(DISABLE_HJ);
    +    test(DISABLE_MJ);
    --- End diff --
    
    We now have `sessionOption("option.name", someValue)` to do this work.


---