Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1059#discussion_r155939358
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractBinaryRecordBatch.java
 ---
    @@ -65,11 +65,20 @@ protected boolean prefetchFirstBatchFromBothSides() {
           return false;
         }
     
    -    if (leftUpstream == IterOutcome.NONE && rightUpstream == 
IterOutcome.NONE) {
    +    if (checkForEarlyFinish()) {
           state = BatchState.DONE;
    +      drainStream(leftUpstream, 0, left);
    +      drainStream(rightUpstream, 1, right);
    --- End diff --
    
    As above on whether draining is a good idea.


---

Reply via email to