[GitHub] drill pull request #1091: DRILL-6071: Limit batch size for flatten operator

[paul-rogers]

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1091#discussion_r162226190
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java
 ---
    @@ -380,14 +394,19 @@ private void measureColumn(ValueVector v, String 
prefix) {
         // vectors do consume space, so visit columns recursively.
     
         switch (v.getField().getType().getMinorType()) {
    -    case MAP:
    -      expandMap((AbstractMapVector) v, prefix + v.getField().getName() + 
".");
    -      break;
    -    case LIST:
    -      expandList((RepeatedListVector) v, prefix + v.getField().getName() + 
".");
    -      break;
    -    default:
    -      v.collectLedgers(ledgers);
    +      case MAP:
    +        expandMap((AbstractMapVector) v, prefix + v.getField().getName() + 
".");
    +        break;
    +      case LIST:
    --- End diff --
    
    Here, check mode. If mode is REPEATED, this is a RepeatedListVector and 
should go down one path. Otherwise, it is a ListVector (possible list of 
unions) and should go down another path.


---