Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1091#discussion_r162846630
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractBase.java
 ---
    @@ -119,6 +119,16 @@ public void setMaxAllocation(long maxAllocation) {
         /*throw new DrillRuntimeException("Unsupported method: 
setMaxAllocation()");*/
       }
     
    +  @Override
    --- End diff --
    
    It the size is a system option, then it need not be passed in each operator 
definition. Note that all operators should use the same batch size, so we'd 
never set this per operator. (The output of one operator is the input to 
another, and the inputs want to be controlled, we can only do that by 
controlling outputs.)


---

Reply via email to