Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1091#discussion_r162846707
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
---
@@ -94,8 +98,57 @@ private void clear() {
}
}
+ private class FlattenMemoryManager {
--- End diff --
The memory manager is an excellent idea. But, it is private. This means we
are passing up one of the key benefits of this kind of manager: the ability to
unit test it separately without needing actual memory or batches. (See the
external sort for an example.)
---
