Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/1091#discussion_r164231963
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
---
@@ -94,8 +98,57 @@ private void clear() {
}
}
+ private class FlattenMemoryManager {
--- End diff --
Memory manager actually requires incoming batch. All the tests in
testOutputBatch are exercising this code. I went down the path of writing tests
just for memory manager. But, they are redundant and doing the same thing I am
doing with the other tests. Also, did not see much point in validating output
row count, since we are interested in batch size more than row count. Please
let me know if you feel otherwise and I can include those tests as well.
---
