[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

[Ben-Zvi]

Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1101#discussion_r164571408
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java
 ---
    @@ -129,11 +143,16 @@ public ColumnSize(ValueVector v, String prefix) {
             // No standard size for Union type
             dataSize = v.getPayloadByteCount(valueCount);
             break;
    +      case GENERIC_OBJECT:
    +        // We cannot provide a size for Generic Objects
    --- End diff --
    
    How can execution ever get here ?  Should we throw a 
UserException.unsupportedError here ?



---