[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

[Ben-Zvi]

Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1101#discussion_r164600675
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java
 ---
    @@ -805,7 +803,12 @@ private IntVector allocMetadataVector(int size, int 
initialValue) {
       }
     
       @Override
    -  public void setMaxVarcharSize(int size) { maxVarcharSize = size; }
    +  public void setKeySizes(Map<String, Integer> keySizes) {
    +    Preconditions.checkNotNull(keySizes);
    +
    +    this.keySizes = CaseInsensitiveMap.newHashMap();
    --- End diff --
    
    Minor: Why does every hash table allocate a new map and copy its values ?  
Can't all just share the keySizes map ?



---