Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1101#discussion_r164611358
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
 ---
    @@ -956,21 +925,8 @@ private void spillAPartition(int part) {
           this.htables[part].outputKeys(currOutBatchIndex, this.outContainer, 
outStartIdxHolder.value, outNumRecordsHolder.value, numPendingOutput);
     
           // set the value count for outgoing batch value vectors
    -      /* int i = 0; */
           for (VectorWrapper<?> v : outgoing) {
             v.getValueVector().getMutator().setValueCount(numOutputRecords);
    -        /*
    --- End diff --
    
    We don't have any facility to take a peek at actual data for debugging. 
While this commented code looks ugly, it allows for easy enabling to look at 
data, if needed (or an example of how to do so, for elsewhere).



---

Reply via email to