Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1144#discussion_r179023675
--- Diff: src/main/resources/checkstyle-suppressions.xml ---
@@ -16,4 +16,13 @@
<!-- Checkstyle Suppressions for Apache Drill -->
<suppressions>
<suppress files="[\\/]generated-sources[\\/]"
checks="AvoidStarImport,NeedBraces"/>
+ <suppress checks="IllegalCatch"
--- End diff --
In ML this is called over-fitting: I think we're adding a bit too much
complexity for too little value. I can just see myself, in a couple of months,
tearing my hair out wondering why the build fails on some perfectly benign
construct...
Maybe explain this rule in a comment?
---
