Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1144#discussion_r179023466
--- Diff: src/main/resources/checkstyle-config.xml ---
@@ -30,10 +30,15 @@
<module name="NeedBraces"/>
+ <module name="IllegalCatch">
--- End diff --
Do we want to do this? Why are all these forbidden? `Throwable` was needed
by @Ben-Zvi in his very first Drill bug fix. `RuntimeException` is the root of
the unchecked exceptions beloved by Drill code and is used as a general
"something went wrong" placeholder.
These are all commented out, but still...
Finally, `IndexOutOfBoundsException` is a perfectly fine exception. Adding
this line is probably handy to catch all reference as part of this fix, but
probably not helpful as a general policy.
---
