Github user parthchandra commented on a diff in the pull request:
    --- Diff: exec/vector/src/main/codegen/templates/ ---
    @@ -509,15 +509,15 @@ public long getTwoAsLong(int index) {
         public ${friendlyType} getObject(int index) {
           org.joda.time.DateTime date = new org.joda.time.DateTime(get(index), 
           date = 
    -      return date;
    +      return new java.sql.Date(date.getMillis());
    --- End diff --
    @jiang-wu Thanks for making these changes. Your fix is on the right track.  
However, I'm not sure if we want to introduce a dependency on JDBC classes in 
the vectors. 
    Take a look at DateAccessor, TimeAccessor, and TimeStampAccessor. These are 
generated from 
    The get methods in these convert from UTC to a Local{Date|Time|TimeStamp}.  
Subsequently they convert to the JDBC type since they are used by the JDBC 
    The vectors should be able to do the same, just returning the 
Local{Date|Time|TimeStamp} object.
    I'm not sure if that might affect tests that depend on timezone though. 
Perhaps @vdiravka can comment. 


Reply via email to