Github user jiang-wu commented on a diff in the pull request:
    --- Diff: exec/vector/src/main/codegen/templates/ ---
    @@ -509,15 +509,15 @@ public long getTwoAsLong(int index) {
         public ${friendlyType} getObject(int index) {
           org.joda.time.DateTime date = new org.joda.time.DateTime(get(index), 
           date = 
    -      return date;
    +      return new java.sql.Date(date.getMillis());
    --- End diff --
    BTW, Drill internally tries to fool around with the timezone to preserve 
the "textual representation" look complex.  I am not convinced this is the 
"right" way to handle time.  But in any case, that is outside of the scope of 
this change.
    I mentioned in the Jira a comment on how such timezone manipulation is 
dangerous and lead to errors.  I ran into that when attempting at creating a 
unit test for the change made in the pull request.


Reply via email to