Github user parthchandra commented on a diff in the pull request:
    --- Diff: exec/vector/src/main/codegen/templates/ ---
    @@ -509,15 +509,15 @@ public long getTwoAsLong(int index) {
         public ${friendlyType} getObject(int index) {
           org.joda.time.DateTime date = new org.joda.time.DateTime(get(index), 
           date = 
    -      return date;
    +      return new java.sql.Date(date.getMillis());
    --- End diff --
    Either one is fine (since java.time is based on Joda). We've switched to 
Java 8, but just for consistency with the rest of the code, we might as well 
use Joda.


Reply via email to