[GitHub] drill pull request #1232: DRILL-6094: Decimal data type enhancements

[vvysotskyi]

Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1232#discussion_r184008307
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java
 ---
    @@ -228,14 +232,33 @@ private void newSchema() throws IOException {
         setUp(schema, consumer);
       }
     
    -  private PrimitiveType getPrimitiveType(MaterializedField field) {
    +  protected PrimitiveType getPrimitiveType(MaterializedField field) {
         MinorType minorType = field.getType().getMinorType();
         String name = field.getName();
    +    int length = ParquetTypeHelper.getLengthForMinorType(minorType);
         PrimitiveTypeName primitiveTypeName = 
ParquetTypeHelper.getPrimitiveTypeNameForMinorType(minorType);
    +    if (DecimalUtility.isDecimalType(minorType)) {
    +      OptionManager optionManager = 
oContext.getFragmentContext().getOptions();
    +      if (optionManager.getString(PARQUET_WRITER_LOGICAL_TYPE_FOR_DECIMALS)
    --- End diff --
    
    Agree, thanks for pointing this, used `writerOptions`.


---