Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1232#discussion_r184012035
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java
---
@@ -409,4 +409,30 @@ public void
testNLJoinCorrectnessRightMultipleBatches() throws Exception {
setSessionOption(ExecConstants.SLICE_TARGET, 100000);
}
}
+
+ @Test
+ public void testNlJoinWithStringsInCondition() throws Exception {
+ try {
+ test(DISABLE_NLJ_SCALAR);
+ test(DISABLE_JOIN_OPTIMIZATION);
+
+ final String query =
--- End diff --
Before my changes similar query but with decimal literal in condition
passed because it was handled as double. But since with my changes decimal
literal is handled as the decimal, it is discovered a bug in nested loop join
which is observed for the types that use drillbuf to shore their value.
---
