Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1232#discussion_r184009513 --- Diff: exec/vector/src/main/codegen/templates/ValueHolders.java --- @@ -32,99 +32,81 @@ /* * This class is generated using freemarker and the ${.template_name} template. */ -public final class ${className} implements ValueHolder{ +public final class ${className} implements ValueHolder { public static final MajorType TYPE = Types.${mode.name?lower_case}(MinorType.${minor.class?upper_case}); - <#if mode.name == "Repeated"> + <#if mode.name == "Repeated"> - /** The first index (inclusive) into the Vector. **/ - public int start; + /** The first index (inclusive) into the Vector. **/ + public int start; - /** The last index (exclusive) into the Vector. **/ - public int end; + /** The last index (exclusive) into the Vector. **/ + public int end; - /** The Vector holding the actual values. **/ - public ${minor.class}Vector vector; + /** The Vector holding the actual values. **/ + public ${minor.class}Vector vector; - <#else> - public static final int WIDTH = ${type.width}; + <#else> + public static final int WIDTH = ${type.width}; - <#if mode.name == "Optional">public int isSet;</#if> - <#assign fields = minor.fields!type.fields /> - <#list fields as field> - public ${field.type} ${field.name}; - </#list> + <#if mode.name == "Optional">public int isSet;</#if> + <#assign fields = minor.fields!type.fields /> + <#list fields as field> + public ${field.type} ${field.name}; + </#list> - <#if minor.class.startsWith("Decimal")> - public static final int maxPrecision = ${minor.maxPrecisionDigits}; - <#if minor.class.startsWith("Decimal28") || minor.class.startsWith("Decimal38")> - public static final int nDecimalDigits = ${minor.nDecimalDigits}; + <#if minor.class.startsWith("Decimal")> + public static final int maxPrecision = ${minor.maxPrecisionDigits}; + <#if minor.class.startsWith("Decimal28") || minor.class.startsWith("Decimal38")> --- End diff -- Thanks, good idea, marked as deprecated and added a comment to use VarDecimalHolder instead.
---