superbstreak commented on a change in pull request #1366: [DRILL-6581] C++
Client SSL Implementation Fixes/Improvements
URL: https://github.com/apache/drill/pull/1366#discussion_r200784366
##########
File path: contrib/native/client/src/clientlib/channel.hpp
##########
@@ -22,6 +22,15 @@
#include "drill/drillClient.hpp"
#include "streamSocket.hpp"
+namespace
+{
+// The global flag to indicate certificate validation error.
+bool s_HostNameValidationError = false;
Review comment:
Test static flag impact.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
