superbstreak commented on a change in pull request #1366: [DRILL-6581] C++
Client SSL Implementation Fixes/Improvements
URL: https://github.com/apache/drill/pull/1366#discussion_r201527041
##########
File path: contrib/native/client/src/clientlib/channel.cpp
##########
@@ -211,6 +211,21 @@ ChannelContext*
ChannelFactory::getChannelContext(channelType_t t, DrillUserProp
}
pChannelContext = new SSLChannelContext(props, tlsVersion,
verifyMode);
+
+ if (props->isPropSet(USERPROP_CUSTOM_SSLCTXOPTIONS)){
Review comment:
This is an optional settings that the client application can set on top of
the default. And also based on the version of boost the client is compiled
against, some configurations are not available. So the user using this function
should be aware of the limitation of the version of boost the client is
compiled against and set the flags accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
