superbstreak commented on a change in pull request #1366: [DRILL-6581] C++
Client SSL Implementation Fixes/Improvements
URL: https://github.com/apache/drill/pull/1366#discussion_r200798541
##########
File path: contrib/native/client/src/clientlib/channel.hpp
##########
@@ -60,11 +66,24 @@ class UserProperties;
class ChannelContext{
public:
- ChannelContext(DrillUserProperties* props):m_properties(props){};
+ ChannelContext(DrillUserProperties*
props):m_properties(props),m_hasCertHostnameVerificationErr(false){};
virtual ~ChannelContext(){};
const DrillUserProperties* getUserProperties() const { return
m_properties;}
+
+ /// @brief Check the certiticate hostname verification status.
+ ///
+ /// @return if the verification has failed.
+ const bool HasCertHostnameVerificationError() const {return
m_hasCertHostnameVerificationErr;}
Review comment:
I think we should put these inside SSLChannelContext since these are SSL
related items
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
