kkhatua commented on a change in pull request #1371: DRILL-6588: Make Sys tables of nullable datatypes URL: https://github.com/apache/drill/pull/1371#discussion_r201527711
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pojo/PojoDataType.java ########## @@ -36,6 +36,7 @@ private final List<SqlTypeName> types = Lists.newArrayList(); private final List<String> names = Lists.newArrayList(); + private final List<Boolean> nullables = Lists.newArrayList(); Review comment: RecordDataType uses the `names` and `types` lists separately. So, I'll need atleast 2 lists. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
