kkhatua commented on a change in pull request #1371: DRILL-6588: Make Sys
tables of nullable datatypes
URL: https://github.com/apache/drill/pull/1371#discussion_r201539183
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/RecordDataType.java
##########
@@ -47,17 +48,22 @@
* @return the constructed type
*/
public final RelDataType getRowType(RelDataTypeFactory factory) {
- final List<SqlTypeName> types = getFieldSqlTypeNames();
+ final List<ImmutablePair<SqlTypeName, Boolean>> types =
getFieldSqlTypeNames();
Review comment:
There are just 2 lists : `names` and `types`.
The third list (`fields`) is used as `factory.createStructType(fields,
names)`
I'm reluctant to change abstract methods because they might have usage
beyond the current SystemTable context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
