kkhatua commented on a change in pull request #1371: DRILL-6588: Make Sys
tables of nullable datatypes
URL: https://github.com/apache/drill/pull/1371#discussion_r201883774
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/RecordDataType.java
##########
@@ -47,17 +48,22 @@
* @return the constructed type
*/
public final RelDataType getRowType(RelDataTypeFactory factory) {
- final List<SqlTypeName> types = getFieldSqlTypeNames();
+ final List<ImmutablePair<SqlTypeName, Boolean>> types =
getFieldSqlTypeNames();
Review comment:
For a one-time usage of creating a nullable RelDataType (since Calcite
doesn't provide a convenient way of doing so), I think a holder class is an
overkill.
I have this option from Calcite:
`https://calcite.apache.org/apidocs/org/apache/calcite/rel/type/RelDataTypeFactory.html#createStructType-java.util.List-`
which also makes use of a list of Map.Entry objects.
So, unless I change Calcite, there is no real value in creating a holder
class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
