vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen
optimization of SQL functions with constant values
URL: https://github.com/apache/drill/pull/1481#discussion_r222621009
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/compile/TestLargeFileCompilation.java
##########
@@ -109,6 +113,20 @@
LARGE_QUERY_FILTER = sb.append(" true") .toString();
}
+ static {
+ final char[] alphabet = "abcdefghijklmnopqrstuvwxyz".toCharArray();
+ int len = 1 << 18;
+ char[] longText = new char[len];
+ for (int j = 0; j < len; ++j) {
+ longText[j] = alphabet[ThreadLocalRandom.current().nextInt(0,
alphabet.length)];
+ }
+ StringBuilder sb = new StringBuilder("select *\n")
+ .append("from cp.`employee.json`\n")
+ .append("where last_name ='")
+ .append(longText).append("'");
Review comment:
Please move the second `append` to the new line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
