vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#discussion_r222614012
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/CodeGenMemberInjector.java ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.physical.impl.common; + +import com.sun.codemodel.JMethod; +import io.netty.buffer.DrillBuf; +import org.apache.drill.exec.expr.ClassGenerator; +import org.apache.drill.exec.expr.holders.ValueHolder; +import org.apache.drill.exec.ops.FragmentContext; +import org.apache.drill.shaded.guava.com.google.common.base.Function; +import org.apache.drill.shaded.guava.com.google.common.base.Throwables; + +import java.lang.reflect.Method; +import java.util.Map; + +public class CodeGenMemberInjector { + + public static void injectMembers(ClassGenerator<?> cg, Object instance, FragmentContext context) { + for (Map.Entry<JMethod, Function<DrillBuf, ? extends ValueHolder>> setter : cg.getSetters().entrySet()) { + try { + JMethod method = setter.getKey(); + Method setMethod = instance.getClass().getMethod(method.name(), + Class.forName(method.params().get(0).type().binaryName())); + setMethod.invoke(instance, setter.getValue().apply(context.getManagedBuffer())); + } catch (Exception e) { + Throwables.propagate(e); Review comment: `Throwables.propagate()` is deprecated. Please replace it with the combination of `Throwables.throwIfUnchecked(e)` and `new RuntimeException(e)` as it is recommended in its javadoc. But anyway, is it necessary to wrap unchecked exceptions into `RuntimeException`? If no, then only `ReflectiveOperationException` may be specified in the catch block and wrapped into `RuntimeException`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
