vdiravka commented on a change in pull request #1494: DRILL-6768: Improve
to_date, to_time and to_timestamp and correspondi…
URL: https://github.com/apache/drill/pull/1494#discussion_r223460844
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestCastEmptyStrings.java
##########
@@ -92,4 +92,36 @@ public void testCastInputTypeNonNullableVarCharToDecimal()
throws Exception {
test("alter system set `drill.exec.functions.cast_empty_string_to_null` =
false;");
}
+
+ @Test
+ public void testCastInputTypeNonNullableVarCharToDateTime() throws Exception
{
+ // Enable the new cast functions (cast empty string "" to null)
+ test("alter system set `drill.exec.functions.cast_empty_string_to_null` =
true;");
Review comment:
Since `drill.exec.functions.cast_empty_string_to_null = true` is used in
every test case, it is possible to set it in the `@BeforeClass`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
