vdiravka commented on a change in pull request #1494: DRILL-6768: Improve to_date, to_time and to_timestamp and correspondi… URL: https://github.com/apache/drill/pull/1494#discussion_r223467905
########## File path: logical/src/main/java/org/apache/drill/common/expression/fn/ToFunctions.java ########## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.common.expression.fn; + +import java.util.HashMap; +import java.util.HashSet; +import java.util.Map; +import java.util.Set; + +import org.apache.drill.common.types.TypeProtos.DataMode; +import org.apache.drill.common.types.TypeProtos.MinorType; + +public class ToFunctions { + + private static Map<MinorType, String> TO_FUNC = new HashMap<>(); + /** The to functions that need to be replaced (if + * "drill.exec.functions.cast_empty_string_to_null" is set to true). */ + private static Set<String> TO_FUNC_REPLACEMENT_NEEDED = new HashSet<>(); + /** Map from the replaced functions to the new ones (for non-nullable VARCHAR). */ + private static Map<String, String> FUNC_REPLACEMENT_FROM_NONNULLABLE_VARCHAR = new HashMap<>(); + /** Map from the replaced functions to the new ones (for non-nullable VAR16CHAR). */ + private static Map<String, String> FUNC_REPLACEMENT_FROM_NONNULLABLE_VAR16CHAR = new HashMap<>(); + /** Map from the replaced functions to the new ones (for non-nullable VARBINARY). */ + private static Map<String, String> FUNC_REPLACEMENT_FROM_NONNULLABLE_VARBINARY = new HashMap<>(); + /** Map from the replaced functions to the new ones (for nullable VARCHAR). */ + private static Map<String, String> FUNC_REPLACEMENT_FROM_NULLABLE_VARCHAR = new HashMap<>(); + /** Map from the replaced functions to the new ones (for nullable VAR16CHAR). */ + private static Map<String, String> FUNC_REPLACEMENT_FROM_NULLABLE_VAR16CHAR = new HashMap<>(); + /** Map from the replaced functions to the new ones (for nullable VARBINARY). */ + private static Map<String, String> FUNC_REPLACEMENT_FROM_NULLABLE_VARBINARY = new HashMap<>(); + + static { + TO_FUNC.put(MinorType.DATE, "to_date"); Review comment: There are more `TO_FUNC` https://drill.apache.org/docs/data-type-conversion/#other-data-type-conversions ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
