vdiravka commented on a change in pull request #1494: DRILL-6768: Improve
to_date, to_time and to_timestamp and correspondi…
URL: https://github.com/apache/drill/pull/1494#discussion_r223341697
##########
File path: exec/java-exec/src/main/codegen/data/Casts.tdd
##########
@@ -61,10 +61,30 @@
{from: "VarChar", to: "TimeStamp", major: "VarCharDate", alias:
"timestamptype"},
{from: "VarChar", to: "Time", major: "VarCharDate", alias: "timetype"},
+ {from: "VarChar", to: "NullableDate", major:
"EmptyStringVarCharDateComplex"},
+ {from: "VarChar", to: "NullableTimeStamp", major:
"EmptyStringVarCharDateComplex"},
+ {from: "VarChar", to: "NullableTime", major:
"EmptyStringVarCharDateComplex"},
+
+ {from: "NullableVarChar", to: "NullableDate", major:
"EmptyStringVarCharDateComplex"},
+ {from: "NullableVarChar", to: "NullableTimeStamp", major:
"EmptyStringVarCharDateComplex"},
+ {from: "NullableVarChar", to: "NullableTime", major:
"EmptyStringVarCharDateComplex"},
Review comment:
* Looks like I have introduced not good major name here a lot time ago,
please replace all `EmptyStringVarChar` to `NullableVarChar`.
* What `DateComplex` means? Looks like just `Date` fully reflect that target
types of converting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
