paul-rogers commented on a change in pull request #1599: DRILL-6903:
SchemaBuilder code improvements
URL: https://github.com/apache/drill/pull/1599#discussion_r245887048
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/record/metadata/AbstractColumnMetadata.java
##########
@@ -87,7 +86,8 @@ public AbstractColumnMetadata(AbstractColumnMetadata from) {
expectedElementCount = from.expectedElementCount;
}
- protected void bind(TupleSchema parentTuple) { }
+ @Override
+ public void bind(TupleMetadata parentTuple) { }
Review comment:
Not sure if an issue here, but the "Schema"/"Metadata" split handles the
fact that the column accessors use these interfaces, but are in the vector
package. The "Metadata" interfaces thus are designed to be visible to vector.
On the other hand, the implementation needed visibility to BatchSchema, which
was defined in java-exec.
So, some careful fiddling was needed to ensure that the column accessors
could work just with the interfaces, leaving the implementations to be defined
in java-exec.
All this can certainly be fixed; just tried to minimize code impact during
the long merge process.
Anyway, the change above may not be an issue, but you now have the context
to understand if it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
